Refactor AppConsole to a shared data model#202
Conversation
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cf8d3ea45
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| appConsoleData.completeExecution(execution.cellId, { | ||
| exitCode: 0, | ||
| }); |
There was a problem hiding this comment.
This always finalizes WebMCP executions as success (exitCode: 0) whenever codeModeExecutor.execute resolves, but execute can resolve even when user code fails (the kernels report failures via stderr/exit code rather than throwing in normal runtime-error cases). In those cases the App Console cell is marked success instead of error, which makes the transcript status inaccurate and can mislead users about whether tool-run code actually succeeded.
Useful? React with 👍 / 👎.
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
1 participant
Summary
Testing